Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix or Remove "bulk_pull_blocks" #986

Closed
rkeene opened this issue Jul 24, 2018 · 1 comment
Closed

Fix or Remove "bulk_pull_blocks" #986

rkeene opened this issue Jul 24, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@rkeene
Copy link
Contributor

rkeene commented Jul 24, 2018

The bootstrap request "bulk_pull_blocks" currently only sends a subset of blocks ("info") rather than a complete set; Additionally, it is paginated in a way that requires sorting (min, max).

Currently nothing uses this primitive and so we could remove it, or, alternatively we could fix it.

In favor of fixing it:

  • It is very fast

In favor of removing it

  • It requires blocks to be sorted by hash value
  • After pulling in all blocks, the whole chain must be assembled and each frontier must be validated with the rest of the network

This ticket is a place to collect comments on how this should proceed.

@rkeene rkeene added this to the V15.0 milestone Jul 24, 2018
@rkeene rkeene modified the milestones: V15.0, V15.1 Aug 9, 2018
@rkeene rkeene modified the milestones: V15.2, V16.0 Aug 22, 2018
@rkeene rkeene self-assigned this Aug 24, 2018
@rkeene
Copy link
Contributor Author

rkeene commented Aug 27, 2018

Let's remove it.

Any calls to this should return empty set with the current semantics.

In a future release when we need a new slot we remove "bulk_pull_blocks" and replace it the new thing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant