Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wallet refactor #1097

Merged
merged 7 commits into from
Aug 25, 2018
Merged

Wallet refactor #1097

merged 7 commits into from
Aug 25, 2018

Conversation

clemahieu
Copy link
Contributor

@clemahieu clemahieu commented Aug 24, 2018 •
edited by rkeene
Loading

Wallet refactor. Fixes #1085.

@cryptocode
Copy link
Contributor

LGTM, been running with this PR for a while without issues.

@rkeene rkeene added this to the V16.0 milestone Aug 24, 2018
@rkeene rkeene requested a review from SergiySW August 24, 2018 14:35
argakiig
argakiig approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@argakiig argakiig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been running tests on a loop overnight, havent had any fail. looks nice 👍

@rkeene rkeene added quality improvements This item indicates the need for or supplies changes that improve maintainability major This item indicates the need for or supplies a major or notable change labels Aug 24, 2018
@clemahieu clemahieu merged commit 98e1c99 into master Aug 25, 2018
@clemahieu clemahieu deleted the wallet_refactor branch August 26, 2018 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@argakiig argakiig argakiig approved these changes

@SergiySW SergiySW Awaiting requested review from SergiySW

Assignees

@clemahieu clemahieu

Labels
major This item indicates the need for or supplies a major or notable change quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@clemahieu @cryptocode @argakiig @rkeene