Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

H3 Header size in magicgui.md incorrectly rendered (small) #141

Closed
lucyleeow opened this issue Jan 22, 2024 · 3 comments · Fixed by #152
Closed

H3 Header size in magicgui.md incorrectly rendered (small) #141

lucyleeow opened this issue Jan 22, 2024 · 3 comments · Fixed by #152
Labels
bug Something isn't working
Milestone

Comments

@lucyleeow
Copy link

lucyleeow commented Jan 22, 2024

🐛 Bug

The header size seems wrong here (and later in the document):

image

'Parameter annotations' is a level '3' header whereas 'Annotating as a Layer subclass' is a level '4' header, but above the level '4' header looks bigger? Code:

https://github.com/napari/docs/blob/4ebdd1614323727d0689fb8c9f4d5bba7accb632/docs/howtos/extending/magicgui.md?plain=1#L168-L183

Is this (potentially) a style theme problem @melissawm ?

@lucyleeow lucyleeow added the bug Something isn't working label Jan 22, 2024
@lucyleeow lucyleeow changed the title Header size incorrect in magicgui.md Header size in magicgui.md incorrectly rendered Jan 22, 2024
@psobolewskiPhD
Copy link
Member

That does look a bit strange.
And I think it should be moved to the theme.
Here's the code in the napari-sphinx-theme:

h3 {
font-weight: 700;
font-size: 1.25rem;
color: var(--napari-color-text-base) !important;
}
h4 {
font-weight: 700;
color: var(--napari-color-text-base) !important;
}

Looks like h3 size is overwriting the default of the theme with a smaller value, compare:

https://github.com/pydata/pydata-sphinx-theme/blob/8cf45f835bfdafc5f3821014a18f3b7e0fc2d44b/src/pydata_sphinx_theme/assets/styles/variables/_fonts.scss#L10-L15

Edit: not sure why the code isn't rendering!

@psobolewskiPhD psobolewskiPhD transferred this issue from napari/docs Jan 22, 2024
@psobolewskiPhD psobolewskiPhD changed the title Header size in magicgui.md incorrectly rendered H3 Header size in magicgui.md incorrectly rendered (small) Jan 22, 2024
@lucyleeow
Copy link
Author

And I think it should be moved to the theme.

I wasn't certain it was due to the theme. I think you can transfer an issue: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository
I don't have the right access to do this though.

@lucyleeow
Copy link
Author

Thanks for moving this!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants