Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Eliminate the empty expansions #19

Open
mbruzek opened this issue Dec 28, 2021 · 0 comments
Open

Eliminate the empty expansions #19

mbruzek opened this issue Dec 28, 2021 · 0 comments

Comments

@mbruzek
Copy link
Contributor

mbruzek commented Dec 28, 2021

While working on the code, I noticed the file lists/acronyms.json contains 23 expansions that are empty.

Such as:

  {
    "abbreviation": "ATM", 
    "source_id": 8, 
    "acronym_id": 1582, 
    "expansion": "", 
    "source": "MAF-SMA"
  },
...
  {
    "abbreviation": "VHDL", 
    "source_id": 8, 
    "acronym_id": 512, 
    "expansion": "", 
    "source": "MAF-SMA"
  },

They all seem to be from the "MAF-SMA" source. I don't see any others with empty acronyms.

I can make a pull request that removes these 23 empty expansions, but I suspect they have expansions but there was a problem with ingest from that source. This lists/acronyms.json file is generated from other sources. If we delete these 23, they will come back in future generations.

Investigate the ingest from the MAF-SMA source for potential problems.

@mbruzek mbruzek changed the title Eliminate the empty expansions! Eliminate the empty expansions Dec 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant