Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up SC_NUMBER_OF_RTS_IN_UINT16 define #126

Open
3 tasks done
jphickey opened this issue Oct 24, 2023 · 0 comments
Open
3 tasks done

Clean up SC_NUMBER_OF_RTS_IN_UINT16 define #126

jphickey opened this issue Oct 24, 2023 · 0 comments
Assignees

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
This define is basically "duplicate information" -- there are always 16 bits in a uint16.

Describe the solution you'd like
Instead, the code should deduce how many bits are in each array element via sizeof(), rather than relying on some other macro that may (or may not) be set correctly.

This definition should be removed, and references to it should be replaced with a more robust method.

Additional context
This is a portability issue, and also makes assumptions about how the bits are encoded into TLM that may not be correct going forward.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Oct 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant