New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix #1411, Make EVS_PktPtr parameter in EVS_AddLog() const #2186

Open

thnkslprpt wants to merge 1 commit into nasa:main from thnkslprpt:fix-1411-make-EVS_PktPtr-parameter-in-EVS_AddLog-const

Contributor

thnkslprpt commented Oct 26, 2022 •

edited

Loading

Checklist

I reviewed the Contributing Guide.
I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

Fixes Const correct parameter inputs in EVS #1411
- Changes EVS_PktPtr parameter in EVS_AddLog() to const.
  - Parameter is not modified, so should be const to better show intent and improve type safety.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on behavior.

Contributor Info
Avi Weiss @thnkslprpt

github-advanced-security bot found potential problems

View reviewed changes

modules/evs/fsw/src/cfe_evs_log.c

@@ @@ -37,7 +37,7 @@ @@
                * See description in header file for argument/return detail
                *
                *-----------------------------------------------------------------*/
-              void EVS_AddLog(CFE_EVS_LongEventTlm_t *EVS_PktPtr)
+              void EVS_AddLog(const CFE_EVS_LongEventTlm_t *EVS_PktPtr)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.


          Fix nasa#1411, Make EVS_PktPtr parameter in EVS_AddLog() const

6662fb2

thnkslprpt force-pushed the fix-1411-make-EVS_PktPtr-parameter-in-EVS_AddLog-const branch from 4ebce48 to 6662fb2 Compare

March 14, 2023 11:38

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet