Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #2610, Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #2611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
Tested all variations of coverage thresholds (above, below, split between functions/lines/branches etc.) to confirm expected behavior.

New checks:
Screenshot 2024-10-11 18 28 42

Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now unless the ALLOWED_MISSED_BRANCHES, ALLOWED_MISSED_LINES and/or ALLOWED_MISSED_FUNCTIONS variables are updated as part of the same PR. This will avoid cases like the present, where there is a gap, and a new PR could theoretically reduce coverage but give no warning of the fact.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow
1 participant