Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update copyright to 2022 - automate this? #4532

Closed
shefalijoshi opened this issue Dec 6, 2021 · 12 comments · Fixed by #4715 or #4775
Closed

Update copyright to 2022 - automate this? #4532

shefalijoshi opened this issue Dec 6, 2021 · 12 comments · Fixed by #4715 or #4775
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@shefalijoshi
Copy link
Contributor

Copyright for openmct files needs to be updated to 2022 (when 2022 comes around).
If possible, this should be automated.

@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Dec 6, 2021
@shefalijoshi shefalijoshi self-assigned this Dec 6, 2021
@depperm
Copy link
Contributor

depperm commented Dec 8, 2021

Related Issue #3979

Will look into automating this. Any suggestions are welcome

@depperm
Copy link
Contributor

depperm commented Dec 17, 2021

US copyright law: https://copyright.gov/title17/title17.pdf

A related question seems to indicate maybe this doesn't necessarily have to be updated

@scottbell
Copy link
Contributor

Will write a little tool to automate this.

@scottbell
Copy link
Contributor

I've got an npm script to do this here:
https://github.com/nasa/openmct/pull/4715/files

@scottbell scottbell self-assigned this Jan 13, 2022
@scottbell scottbell linked a pull request Jan 14, 2022 that will close this issue
8 tasks
@unlikelyzero
Copy link
Collaborator

@scottbell can you write test instructions here?

@scottbell
Copy link
Contributor

To test, run the script and ensure neither the string 2020 nor 2021 exist in the codebase. Also check through git diff that only copyrights we’re affected.

@michaelrogers
Copy link
Contributor

michaelrogers commented Jan 24, 2022

Testathon 2022-01-24

The script is working as expected, though on the release/1.8.4 branch still has instances of non 2022 years in the copyright text.

The script will need to be rerun to resolve an older copyright on the following files:
modified: example/exampleUser/ExampleUserProvider.js
modified: example/exampleUser/exampleUserCreator.js
modified: example/exampleUser/plugin.js
modified: example/exampleUser/pluginSpec.js
modified: src/api/user/User.js
modified: src/api/user/UserAPI.js
modified: src/api/user/UserAPISpec.js
modified: src/api/user/constants.js
modified: src/plugins/persistence/couch/CouchSearchProvider.js
modified: src/plugins/userIndicator/components/UserIndicator.vue
modified: src/plugins/userIndicator/plugin.js
modified: src/plugins/userIndicator/pluginSpec.js

@unlikelyzero
Copy link
Collaborator

@scottbell can you take a look?

@scottbell
Copy link
Contributor

Ah, these were all modified/added after the previous PR. @unlikelyzero how do you want to handle this going forward?

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jan 25, 2022

@scottbell can you make another PR against release/1.8.4 with those changes?

I'm not sure if we need to automate this any further. This was likely just a case of a bad backmerge, right?

@scottbell
Copy link
Contributor

https://github.com/nasa/openmct/pull/4775/files

Yeah, this was caused by people creating new files before my PR went in. It should happen less and less.

@scottbell scottbell linked a pull request Jan 25, 2022 that will close this issue
15 tasks
@unlikelyzero unlikelyzero mentioned this issue Jan 25, 2022
15 tasks
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 01/26/22 - All files referenced were updated

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants