Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Build] npm run clean script references absolute path instead of relative for node_modules #4800

Closed
unlikelyzero opened this issue Jan 27, 2022 · 2 comments · Fixed by #4801
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

Summary

npm run clean is designed to clean the dist and node_modules folder. With the current implementation, it uses a relative path for ./dist but an absolute path /node_modules . Effectively, this means that node_modules are not cleaned on personal devices.

@unlikelyzero
Copy link
Collaborator Author

Testing Notes

npm install;npm run clean on any branch other than master (after this change). Note that node_modules folder persists
npm install;npm run clean after switching to a branch with this change. Note that node_modules folder is cleaned

@michaelrogers
Copy link
Contributor

Fix working as expected and verified in testathon 2022-02-17.

@michaelrogers michaelrogers removed their assignment Feb 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants