Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[clock] timezone dropdown once expanded does not collapse #4878

Closed
2 of 5 tasks
nikhilmandlik opened this issue Feb 17, 2022 · 5 comments · Fixed by #4956
Closed
2 of 5 tasks

[clock] timezone dropdown once expanded does not collapse #4878

nikhilmandlik opened this issue Feb 17, 2022 · 5 comments · Fixed by #4956
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue needs:e2e Needs an e2e test source:community Community contribution or request type:bug
Milestone

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Feb 17, 2022

Summary

clock object: When creating/editing, timezone dropdown once open should be able to dismiss when click outside or on dropdown icon again

Expected vs Current Behavior

timezone dropdown once expanded does not collapse

Steps to Reproduce

  1. create menu, try to create clock object
  2. click on dropdown near to timezone value
  3. should expand timezone list
  4. now try to click dropdown icon again to collapse list
  5. it does not collapse

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Feb 18, 2022
@unlikelyzero
Copy link
Collaborator

Adding e2e label. This needs a test.

@unlikelyzero unlikelyzero added bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue labels Feb 18, 2022
@SyedAhmedCU
Copy link
Contributor

I would love to fix this issue, if no one is looking at it. Already I have a working solution, just need to polish the code a bit more. I should be able to create a PR by the end of today :)

@jvigliotta
Copy link
Contributor

Hello @SyedAhmedCU ! Do you have submitted a CLA? I didn't see one on file with us, if you'd like to contribute (which would be awesome!) we'll need you to follow the steps outlined here: #3821 once that's done, we can merge in your contributions. Any questions let me know! Thanks!

@SyedAhmedCU
Copy link
Contributor

Hi @jvigliotta , I have sent the signed CLA to the emails mentioned in the pdf. I also created a PR that fixes the issue. Let me know if you have any suggestions. Thanks!

@unlikelyzero
Copy link
Collaborator

Testing Instructions

Steps to Reproduce
create menu, try to create clock object
click on dropdown near to timezone value
should expand timezone list
now try to click dropdown icon again to collapse list
it does not collapse

@unlikelyzero unlikelyzero added source:community Community contribution or request Target:2.0.2 labels Mar 31, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue needs:e2e Needs an e2e test source:community Community contribution or request type:bug
Projects
None yet
4 participants