Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Plots] "Grab" cursor should be shown when panning #4911

Closed
4 of 5 tasks
akhenry opened this issue Mar 3, 2022 · 5 comments
Closed
4 of 5 tasks

[Plots] "Grab" cursor should be shown when panning #4911

akhenry opened this issue Mar 3, 2022 · 5 comments
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:medium type:bug
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Mar 3, 2022

Summary

Plots should show a grab cursor when the user is panning in a plot.

Steps to Reproduce

  1. Navigate to a plot
  2. Hold down the option key (in Mac OS) while hovering the cursor over the plot
  3. Notice that the cursor does not turn into the grab cursor as it used to.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

Refer to the panning gesture in the time conductor for an example of what the cursor should look like while panning plots.

@akhenry
Copy link
Contributor Author

akhenry commented Mar 3, 2022

Categorizing as medium severity because it affects the discoverability of the pan gesture in plots, which is an important part of user workflows.

@unlikelyzero
Copy link
Collaborator

Testing Notes

Mac OS

Navigate to a plot
Hold down the option key (in Mac OS) while hovering the cursor over the plot
Notice that the cursor turns into grab cursor

Windows

Repeat

@unlikelyzero
Copy link
Collaborator

akhenry to verify with a windows machine

@akhenry
Copy link
Contributor Author

akhenry commented Apr 4, 2022

Verified fixed in Windows and MacOS

@akhenry akhenry closed this as completed Apr 4, 2022
@akhenry akhenry removed the unverified label Apr 4, 2022
@unlikelyzero
Copy link
Collaborator

e2e Testing Notes

Note: much of this functionality can be found in the

const panHotkey = process.platform === 'linux' ? ['Control', 'Alt'] : ['Alt'];
suite

e2e/test/plugins/plot/plotInteractivity.e2e.spec.js

test.describe('Plot and Cursor Tests')
test('Can Pan on plot with Alt+mouse')\
1. Create Overlay Plot
2. Create example Imagery under Overlay Plot
3. Page.goto() Overlay plot
4. hover over plot and detect mouse input type
5. hold down alt key. Detect mouse input type

@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label May 5, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:medium type:bug
Projects
None yet
Development

No branches or pull requests

3 participants