Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No source maps in development mode #5497

Closed
1 of 7 tasks
ozyx opened this issue Jul 13, 2022 · 2 comments · Fixed by #5498
Closed
1 of 7 tasks

No source maps in development mode #5497

ozyx opened this issue Jul 13, 2022 · 2 comments · Fixed by #5498
Labels
bug:regression It used to work. Now it doesn't :( type:bug

Comments

@ozyx
Copy link
Member

ozyx commented Jul 13, 2022

Summary

Recently, we updated app.js to conditionally use webpack.dev.js if NODE_ENV === 'development'. However, this is never set, causing OpenMCT to use production/test webpack configs. This is breaking sourcemaps in development mode.

Fix is to also use webpack.dev.js if NODE_ENV is not set.

Expected vs Current Behavior

OpenMCT should produce sourcemaps in development mode, but it's not.

Steps to Reproduce

  1. Ensure NODE_ENV is not set: unset NODE_ENV
  2. npm install
  3. npm start
  4. Examine the source and notice there are no sourcemaps

Environment

  • Open MCT Version: release/2.0.5
  • Deployment Type: local
  • OS: any
  • Browser: any

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@ozyx ozyx added the type:bug label Jul 13, 2022
@ozyx ozyx self-assigned this Jul 13, 2022
@ozyx ozyx added the bug:regression It used to work. Now it doesn't :( label Jul 13, 2022
@ozyx
Copy link
Member Author

ozyx commented Jul 13, 2022

Testing Instructions

  1. Follow steps to reproduce
  2. See that source maps are generated

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 8/11

Source maps showing when NODE_ENV is unset, or set to 'development'.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants