Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add user author attribution to objects #5656

Closed
akhenry opened this issue Aug 12, 2022 · 3 comments · Fixed by #5741 or #5827
Closed

Add user author attribution to objects #5656

akhenry opened this issue Aug 12, 2022 · 3 comments · Fixed by #5741 or #5827
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
Current objects have a modified and a persisted time associated with them. We should also a user attribution to objects, as we now do with notebook entries.

Describe the solution you'd like
"createdBy" and "modifiedBy" fields could be added and automatically populated with the logged in user, if available.

@jvigliotta
Copy link
Contributor

jvigliotta commented Sep 9, 2022

Testing

  • create an object (Folder, Notebook, Plot, etc) in an instance of Open MCT with a user provider and a logged in user
  • select the object and look at the inspector to see if there are createdBy and modifedBy fields
  • have another user edit the object in ANY way (name, properties, etc)
  • verify that the modifiedBy field has been updated to the new user
  • changes affect create/update/remove make sure you can normally save, update and remove objects
    • when viewing an object that has no sibling objects in it's parent's composition, remove the object and make sure you are navigated correctly to the parent
  • do all of these tests using local storage persistence as well as couchDB persistence

@jvigliotta
Copy link
Contributor

#5903 follow up for visual test

@michaelrogers
Copy link
Contributor

Fix verified in testathon on 10/24/2022. If a object is modified, the change is correctly attributed to the user that last updated the domain object. When deleting the object, the user is properly navigated back to the parent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
4 participants