Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proposal: Require reviewer to smoke test before merge #5770

Closed
akhenry opened this issue Sep 15, 2022 · 0 comments · Fixed by #5771
Closed

Proposal: Require reviewer to smoke test before merge #5770

akhenry opened this issue Sep 15, 2022 · 0 comments · Fixed by #5771
Assignees
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Sep 15, 2022

Summary

Reviewers should test changes by running through provided test procedures once before merge.

Justification

  • Ensures that test procedures exist
  • Ensures that test procedures are sufficient for a third party to test the change.
  • Finds issues that will block testing before the change even goes in.
  • All of the above will save significant time in testathons.

Note

This means that neither the author nor the reviewer should test a change in testathon. As well as more efficient testathons, we get a third set of eyes on every change.

@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Sep 15, 2022
@akhenry akhenry self-assigned this Sep 15, 2022
@unlikelyzero unlikelyzero added this to the Target:2.1.1 milestone Sep 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants