Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add vcrpy cassettes for revision_date unit tests #70

Closed
chuckwondo opened this issue Jul 23, 2024 · 2 comments · Fixed by #71
Closed

Add vcrpy cassettes for revision_date unit tests #70

chuckwondo opened this issue Jul 23, 2024 · 2 comments · Fixed by #71

Comments

@chuckwondo
Copy link
Collaborator

New unit tests recently added for testing new revision_date search functionality are missing vcrpy cassettes to prevent unit tests from making live requests. This can lead to broken tests in the future, should the responses change.

Specifically, these tests need to be supported by vcrpy cassettes:

  • test_revision_date in tests/test_collection.py
  • test_revision_date in tests/test_granule.py
@frankinspace
Copy link
Collaborator

@chuckwondo it doesn't like any of the test functions in tests/test_collection.py or tests/test_granule.py are using vcrpy as far as I can tell? We should add it for all these tests in that case.

@chuckwondo
Copy link
Collaborator Author

@chuckwondo it doesn't like any of the test functions in tests/test_collection.py or tests/test_granule.py are using vcrpy as far as I can tell? We should add it for all these tests in that case.

Correct. We haven't needed to use it in those files yet, as none of the tests make any http requests. Only the new tests for revision date actually make http requests. The rest of the tests simply construct query instances without actually executing the queries.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants