Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hardcoded arguments for "Feature Extraction of DeLF" #3

Open
clungzta opened this issue Mar 19, 2019 · 1 comment
Open

Hardcoded arguments for "Feature Extraction of DeLF" #3

clungzta opened this issue Mar 19, 2019 · 1 comment

Comments

@clungzta
Copy link

Thanks for the implementation!

In the readme, examples are provided of arguments being passed into the (1) train PCA and (2) extract dimension reduced DeLF steps. However, all the values are hardcoded in extract.py. Thus, the steps in the main README are somewhat misleading.

Is there specific resoning for hardcoding the extract parameters, but passing the train parameters?

I feel that it would be quite convenient to pass all extract parameters from cli.

@nashory
Copy link
Owner

nashory commented Mar 19, 2019

Hi @clungzta,
There is no reason for the hardcoding. you are free to change the extractor.py file using python argparse so the parameters can be delivered via cli.
It would be grateful if you create pr.
Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants