You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the readme, examples are provided of arguments being passed into the (1) train PCA and (2) extract dimension reduced DeLF steps. However, all the values are hardcoded in extract.py. Thus, the steps in the main README are somewhat misleading.
Is there specific resoning for hardcoding the extract parameters, but passing the train parameters?
I feel that it would be quite convenient to pass all extract parameters from cli.
The text was updated successfully, but these errors were encountered:
Hi @clungzta,
There is no reason for the hardcoding. you are free to change the extractor.py file using python argparse so the parameters can be delivered via cli.
It would be grateful if you create pr.
Thanks!
Thanks for the implementation!
In the readme, examples are provided of arguments being passed into the (1) train PCA and (2) extract dimension reduced DeLF steps. However, all the values are hardcoded in
extract.py
. Thus, the steps in the main README are somewhat misleading.Is there specific resoning for hardcoding the extract parameters, but passing the train parameters?
I feel that it would be quite convenient to pass all extract parameters from cli.
The text was updated successfully, but these errors were encountered: