Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Improved css bundle support #99

Merged
merged 6 commits into from
Sep 28, 2018
Merged

Conversation

vtrifonov
Copy link
Contributor

Refactored webpack.config.js file for better css/scss support.

@rigor789
Copy link
Member

Seems like nativescript-dev-webpack versions above 0.17.0-2018-09-27-191217-06 are missing the style-hot-loader and apply-css-loader files.

I'll wait before merging, to avoid issues due to the missing files.

@rigor789
Copy link
Member

I also noticed that there is no way to remove css at runtime. If you delete a css property and the app syncs with hmr, the property will still affect the app.

Example:

<Label class="message"/>
.message {
  font-size: 20;
  color: red;
}

If I remove color: red; the label stays red until I restart the tns commands. Changing it to blue does work though. Do you know where this could be implemented?

@vtrifonov
Copy link
Contributor Author

Seems like nativescript-dev-webpack versions above 0.17.0-2018-09-27-191217-06 are missing the style-hot-loader and apply-css-loader files.

I'll wait before merging, to avoid issues due to the missing files.

This happens because of the ^ in front, seems that it takes the version from RC which does not contain those loaders, so I'm using a concrete version now.

@sis0k0
Copy link
Contributor

sis0k0 commented Sep 28, 2018

@vtrifonov, you can use the next tag as well.

@vtrifonov
Copy link
Contributor Author

I also noticed that there is no way to remove css at runtime. If you delete a css property and the app syncs with hmr, the property will still affect the app.

Example:

<Label class="message"/>
.message {
  font-size: 20;
  color: red;
}

If I remove color: red; the label stays red until I restart the tns commands. Changing it to blue does work though. Do you know where this could be implemented?

This seems like something that need to be implemented in the tns-core-modules, could you log an issue there about it?

@rigor789 rigor789 merged commit 1e9929a into nativescript-vue:master Sep 28, 2018
@rigor789
Copy link
Member

@vtrifonov thanks, will open an issue about the css unloading.

@rigor789
Copy link
Member

NativeScript/NativeScript#6320

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants