Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Getting returning True from eof_received() has no effect when using ssl #574

Open
thierryba opened this issue Jun 19, 2024 · 4 comments
Open
Assignees
Labels
defect Suspected defect such as a bug or regression

Comments

@thierryba
Copy link

Observed behavior

when I create a client with TLS on, it works but when I can drain, I am getting a message:
returning True from eof_received() has no effect when using ssl

Expected behavior

That message should not show.

Server and client version

nats-server: v2.10.12
nats_py-2.7.2

Host environment

macOS 14

Steps to reproduce

my code is really just doing this (contains TLS client certificate too):
nats_client = await nats.connect(**create_nats_options('FW Clients', err_cb))
await nats_client.drain()

and that shows the error.

@thierryba thierryba added the defect Suspected defect such as a bug or regression label Jun 19, 2024
@outsystemsToby
Copy link

Just wanted to add that we started getting this message when upgrading a project from python 3.10 to 3.11.

@Shrikey
Copy link

Shrikey commented Sep 10, 2024

Same here: warning sslproto.py _call_eof_received():811: returning true from eof_received() has no effect when using ssl

@zsblevins
Copy link

Also seeing this when migrating from 3.10 to 3.11

@vetlesim
Copy link

Still an issue with python 3.12. This is a known issue with a known fix. The proposed solution solves the issue in nats.py as well, i.e. calling protocol.connection_made(transport) in TcpTransport.connect_tls().

@caspervonb

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

6 participants