ACI sync fails if LocationType is not "site"

[kingfetty]

Environment

• Python version: 3.11
• Nautobot version: 2.3.8
• nautobot-ssot version: 3.2.0

Expected Behavior

SSOT [ACI] should sync regardless of location type. Not all implementations will use "site" location type.

Observed Behavior

Attempting to sync aci data if location type "site" does not exist results in failure

Steps to Reproduce

1. Configure SSOT [ ACI ] Plugin
2. Setup location types with no location type called "site"
3. Attempt to sync data.

[jdrew82]

@kingfetty Have you tested 3.3.0? I don't think this is an issue any longer.

[kingfetty]

@jdrew82 Yes this is still an issue in 3.3.0 and have tested as such.

Attempting to sync ACI without a LocationType named "Site" produces the following Job resutl:

{
    "exc_message": [
        "Location matching query does not exist."
    ],
    "exc_module": "nautobot.dcim.models.locations",
    "exc_type": "Location.DoesNotExist"
}

If you examine the source code in the ACI diffsync model:
https://github.com/nautobot/nautobot-app-ssot/blob/develop/nautobot_ssot/integrations/aci/diffsync/models/nautobot.py

You will see the create, update, and delete functions all rely on querying the location by specifying the LocationType must be "Site"

Create:
location=Location.objects.get(name=ids["site"], location_type=LocationType.objects.get(name="Site"))

Update/Delete:
location=Location.objects.get(name=self.site, location_type=LocationType.objects.get(name="Site")),

[jdrew82]

@kingfetty I see it now. Apologies for missing this before. I've gone ahead and got a fix coming shortly.