Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Please reconsider the ability to disable thread level metrics. #67

Closed
ickymettle opened this issue Oct 9, 2018 · 1 comment
Closed

Comments

@ickymettle
Copy link

Hi, first up thanks so much for process-exporter we use it really heavily. Unfortunately for the production systems we monitor with process exporter we need the ability to disable the collection of per-thread metrics.

One of the key processes we monitor with process-exporter has anywhere from 200-300k threads on a good day, the overhead of collecting these is excessive and renders the latest release of process-exporter essentially useless for the task we use it for.

Would it be possible for the change to remove the ability to disable thread metric collection be reverted?

@ncabatoff
Copy link
Owner

Hi @ickymettle,

I was afraid that there might be a user out there like you, but I took a chance because the state metrics are essentially meaningless without the thread info. I'm sorry to have broken behaviour you depend on. I will find a way to accommodate both our needs - probably something close to a revert of the change, but making the current behaviour be the default and the one you desire be opt-in with a -no-threads option.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants