Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Horizon ID harmonization in fetch functions #113

Closed
brownag opened this issue Nov 5, 2019 · 0 comments
Closed

Horizon ID harmonization in fetch functions #113

brownag opened this issue Nov 5, 2019 · 0 comments
Assignees

Comments

@brownag
Copy link
Member

brownag commented Nov 5, 2019

When a data source already has a logical unique horizon identifier, the fetchX() functions should use it instead of the default of calculating one with 1:nrow(spc@horizons)

fetchNASIS_pedons(): hzidname(spc) <- 'phiid'
fetchNASISLabData(): hzidname(spc) <- 'phiid'
fetchPedonPC(): hzidname(spc) <- 'phiid'
fetchRaCA()$pedons: hzidname(spc) <- 'phiid'

fetchNASIS_components(): hzidname(spc) <- 'chiid'

fetchKSSL(): hzidname(spc) <- "labsampnum"

fetchRaCA()$samples: hzidname(spc) <- 'sample_id'

fetchNASISWebReport: hzidname(spc) <- 'chkey'
fetchSDA_component: hzidname(spc) <- 'chkey'

Any objections? Any ones I missed? I am thinking this standard will be handy with implementation of horizon setter changes in aqp

@brownag brownag self-assigned this Nov 5, 2019
@brownag brownag closed this as completed in 4ca51ce Nov 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant