Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(addStateInChain) : Add showAbstract to ncyBreadcrumb options #78

Merged
merged 2 commits into from
Mar 27, 2015
Merged

feat(addStateInChain) : Add showAbstract to ncyBreadcrumb options #78

merged 2 commits into from
Mar 27, 2015

Conversation

KodeShark
Copy link
Contributor

Give ability to show specific abstract states, even if options.includeAbstract is turned off in configuration

Give ability to show specific abstract states, even if options.includeAbstract is turned off in configuration
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 96.64% when pulling 31125a3 on KodeShark:showAbstract into 884d9ac on ncuillery:master.

@ncuillery
Copy link
Owner

Hi,

Thank for the PR, clean, tested and I like your way of writing conditions.

I have 2 comments:

  • How about force instead of showAbstract ? I will be consistent with the existing skip option.
  • I would like to have a test case with both skip & force option set to true (The result doesn't really matter, I just need to write what's happen in this case in the docs).

Can you do this ?

@KodeShark
Copy link
Contributor Author

Sure. I actually had it set to force initially, but thought it may be too vague to the end user.

Give ability to show specific abstract states, even if options.includeAbstract is turned off in configuration
@ncuillery ncuillery merged commit 52c284b into ncuillery:master Mar 27, 2015
@ncuillery
Copy link
Owner

Merged, thanks @KodeShark !

@epelc
Copy link

epelc commented Apr 23, 2015

@ncuillery Was this not released? I can't seem to find it in 0.3.3.

@samzhao
Copy link

samzhao commented May 16, 2015

@epelc for now I think you'll have to use what's on master bower install --save angular-breadcrumb#master

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants