Handle parents provided by StateObject references #82
Conversation
|
Changes Unknown when pulling 88e8f51 on paweld2:master into * on ncuillery:master*. |
|
Changes Unknown when pulling cfe86aa on paweld2:master into * on ncuillery:master*. |
|
Changes Unknown when pulling f76c018 on paweld2:master into * on ncuillery:master*. |
| if( typeof parent === "object" ) { | ||
| // if parent is a object reference, then extract the name | ||
| name = parent.name; | ||
| } |
There was a problem hiding this comment.
How about a ternary operator like this one ?
|
Thanks for the PR, clean and tested ! I just leave a note above. Additionally, can you amend the commit and type this message: |
|
Changes Unknown when pulling f4288d3 on paweld2:master into * on ncuillery:master*. |
|
Code fixed and message changed. |
|
Changes Unknown when pulling f4288d3 on paweld2:master into * on ncuillery:master*. |
|
Landed, thanks a lot ! |
In the case that the 'parent' property of a state is provided as a reference to a StateObject, the function $$parentState returns a reference to the State object and not the state name. On this case the application crash.
I added a test case for this and a fix on $$parentState.