Account that is created in a failing transaction may show up on the list in Explorer

[frol]

Story

As a user who uses Explorer Accounts page, I want to know the correct information about the accounts.

It seems that currently, we may include an account from a CreateAccount action of a transaction that actually failed.

To resolve this we need to query individual transactions (since near/nearcore#1880 is not implemented yet) to know the status. While we are at it, we can also store this status in Explorer DB, so we don't need to query it from the node again and again.

This should be resolved with #218.

Acceptance Criteria

• There should be no "ghost" accounts

[frol]

@bowenwang1996

In the case where the account is created through a transaction, you can check the final status of the transaction to see whether it succeeded or not. I understand that we still cannot track the accounts created through function calls, but I think we can at least make sure we don't display accounts that do not exist.

We cannot reason about the success of the whole transaction (#212 (comment), see (3)), and we don't track receipts here to match the execution outcome to it. /cc @khorolets FYI

[bowenwang1996]

We cannot reason about the success of the whole transaction

why? transaction status query allows you to check statuses of all receipts.

[frol]

@bowenwang1996 While it does, the receipts are applied independently, so the receipt that creates an account may succeed while the transaction may still contain some receipts that fail. To know whether an account was created or not, we need to track the receipt and its execution outcome (which will only be the case once we land the Indexer for Explorer)

[frol]

Resolved in Explorer baked by the Indexer for Explorer (see #236).