Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace use of lazy_static_include_bytes in tests with std::fs::read #6665

Closed
mina86 opened this issue Apr 21, 2022 · 3 comments · Fixed by #6729
Closed

Replace use of lazy_static_include_bytes in tests with std::fs::read #6665

mina86 opened this issue Apr 21, 2022 · 3 comments · Fixed by #6729
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. P-low Priority: low

Comments

@mina86
Copy link
Contributor

mina86 commented Apr 21, 2022 •
edited by exalate-issue-sync bot
Loading

#6654 (review)
@mina86 mina86 added P-low Priority: low C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. labels Apr 21, 2022
@abhijeetbhagat
Copy link
Contributor

i can work on this. can you please confirm that this needs to be done only in the tests and not elsewhere?

@mina86
Copy link
Contributor Author

mina86 commented Apr 29, 2022

That’s correct.

@abhijeetbhagat
Copy link
Contributor

Ok, on it.

@abhijeetbhagat abhijeetbhagat mentioned this issue Apr 30, 2022
Merged
mina86 pushed a commit that referenced this issue May 1, 2022
@abhijeetbhagat
replace use of lazy_static_include_bytes in tests with std::fs::read (#…
960c8eb 
…6729)

Replace use of `lazy_static_include_bytes` in tests with `std::fs::read`

Since we don’t need to include test data files in test binaries,
prefer reading the files via `std::fs::read` rather than using
`lazy_static_include_bytes`.  In release builds the latter results in
the file being read at compilation which is a waste of time.

Fixes: #6665
EdvardD pushed a commit that referenced this issue May 6, 2022
@abhijeetbhagat @EdvardD
replace use of lazy_static_include_bytes in tests with std::fs::read (#…
03b1aa5 
…6729)

Replace use of `lazy_static_include_bytes` in tests with `std::fs::read`

Since we don’t need to include test data files in test binaries,
prefer reading the files via `std::fs::read` rather than using
`lazy_static_include_bytes`.  In release builds the latter results in
the file being read at compilation which is a waste of time.

Fixes: #6665
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. P-low Priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace use of lazy_static_include_bytes in tests with std::fs::read
2 participants
@mina86 @abhijeetbhagat