open tomli file with newline='' #1196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
graingert
commented
Jul 30, 2021
| @@ -40,7 +40,7 @@ def read(self, filenames): | |||
| filename = os.fspath(filenames) | |||
|
|
|||
| try: | |||
| with open(filename, encoding='utf-8') as fp: | |||
| with open(filename, encoding='utf-8', newline='') as fp: | |||
There was a problem hiding this comment.
@hukkin do you have a test file that breaks without newline=''?
There was a problem hiding this comment.
Any file that has a CR character not immediately followed by a LF character. The most simple example is a one byte file with just the CR character (0x0D).
That is invalid TOML and should raise an error, but doesn't if newline='' is not set.
There was a problem hiding this comment.
Thanks, I'll push a test case tomorrow
nedbat
force-pushed
the
master
branch
2 times, most recently
from
0c14f1a
to
82169a6
Compare
|
I know this is a draft, but is it still valid? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.