Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DWF Calculator improvements [to be discussed] #582

Closed
leendertvanwolfswinkel opened this issue Jul 16, 2021 · 1 comment
Closed

DWF Calculator improvements [to be discussed] #582

leendertvanwolfswinkel opened this issue Jul 16, 2021 · 1 comment
Labels
Info needed Further information is requested

Comments

@leendertvanwolfswinkel
Copy link
Collaborator

leendertvanwolfswinkel commented Jul 16, 2021

  • Replace spatialite input selector with a normal file selector with .sqlite filter
  • Rename: 'Start time of day (HH:MM:SS)' --> 'DWF Timeseries start time (HH:MM:SS)'
  • Rename: 'Simulation duration' --> 'DWF timeseries duration (seconds)'
  • Limit the DWF timeseries duration (seconds) to the range 1 to 86.400 seconds (24h)
  • Rename: 'DWF progress file (.csv)' --> 'Intra-day distribution (.csv)'
  • Below the 'Intra-day distribution' file selector, add a editable table widget (24 rows, 2 columns ["hour","fraction") showing the current distribution, pre-filled with the defaults the tool uses. Loading a CSV should overwrite the values in the table widget, but the values used by the algorithm should always be the ones in the table widget.
  • The above is too complex to implement in a Processing tool UI, but if it is possible, would be great. Other option is to just have the table widget pre-filled with defaults, and instead of loading a csv, users can copy-paste their data.
  • Add option to use DWF in surfaces (as opposed to impervious surfaces) as input

Other idea: simplify this tool to always produce a 24h timeseries from 12 midnight to 12 midnight, and let the 3Di API Client plugin select a subset from this timeseries based on simulation start time / end time and if simulation duration > 24h, repeat the dwf timeseries

@Patrick-Nijman Patrick-Nijman added the Info needed Further information is requested label Aug 25, 2021
@leendertvanwolfswinkel leendertvanwolfswinkel changed the title DWF Calculator finishing touch before release [to be discussed] DWF Calculator improvements [to be discussed] Jan 25, 2022
@leendertvanwolfswinkel leendertvanwolfswinkel removed this from the 3.1 After refactor milestone Nov 13, 2023
@leendertvanwolfswinkel
Copy link
Collaborator Author

Replaced by #1050

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Info needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants