Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove v2_ prefixes (threedigrid) #248

Open
leendertvanwolfswinkel opened this issue Oct 17, 2024 · 3 comments
Open

Remove v2_ prefixes (threedigrid) #248

leendertvanwolfswinkel opened this issue Oct 17, 2024 · 3 comments

Comments

@leendertvanwolfswinkel
Copy link
Contributor

content_type values should be updated according to the new table names (v2_weir -> weir, v2_pumpstation -> pump etc)

@margrietpalm
Copy link

margrietpalm commented Nov 15, 2024

Should be resolved in 1D migration, but lets dubble check Didn't resolve this.

@martijn-siemerink do you think it's a good idea to modify this in threedigrid?

@jpprins1
Copy link
Contributor

jpprins1 commented Dec 9, 2024

The content_type field is exposed to the outside (so part of the public API) and therefore we cannot change this because of backwards compatibility.

@margrietpalm
Copy link

Conlcusion: no changes will be made but the usage of v2_ prefixes will be described in the documenation by @leendertvanwolfswinkel

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants