feat: implement history #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raise an error if directory does not exist - Raise an error if path exists but it is not a directory
- History file syntax is the following: `exit_code: command` TODO: add `Up` and `Down` arrows in `core/input.rs` to browse history
* main: chore(input): format, add data type to `buffer_len` declaration in `End` key body feat(input): add `Home` and `End` keys
7 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to re-implement history saving, closing #23 by implementing last missing feature on that issue.
These changes are still in a very early stage, currently we are capable of creating history file (it is being created at data directory and is named
neosh_history, e.g. this is the path in *nix systems:~/.local/share/neosh/neosh_history) and saving it.We are saving everything we can right now, that means we are saving built-in commands history with their exit codes (some of them are hard-coded to
0at the moment due to their nature, e.g.echoorpwd), Lua chunks (NeoSH stdlib, Lua stdlib, functions, variables declaration, etc) and failed Lua commands.Missing functionalities to be added before merging:
history::getto return a vector with each history line instead of returning history as a string (this can be really hard for Lua chunks with incomplete input like functions in multiple lines).UpandDownarrow keys insrc/core/input.rsto browse history, whereUpgets previous history entry andDowngets the next one, like BASH or ZSH.Notes:
Page UpandPage Downkeys to do the same thing as theUpandDownarrow keys like in ZSH.