Skip to content

memory leak in logging usage #359

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
if6was9 opened this issue Apr 21, 2017 · 4 comments
Closed

memory leak in logging usage #359

if6was9 opened this issue Apr 21, 2017 · 4 comments

Comments

@if6was9
Copy link

if6was9 commented Apr 21, 2017

There is a severe memory leak here:

https://github.com/neo4j/neo4j-java-driver/blob/1.3/driver/src/main/java/org/neo4j/driver/internal/NetworkSession.java#L65

Our application ends up in GC hell after running for a few days. Here is a chart from new relic that shows this:

image

I'll submit a PR shortly.

@if6was9
Copy link
Author

if6was9 commented Apr 21, 2017

#360

@lutovich
Copy link
Contributor

Hello @if6was9,

Java driver 1.2.2 was released yesterday and is now available in maven central. Could you please try it out to confirm that this issue is resolved?

Thanks.

@lutovich
Copy link
Contributor

Hello @if6was9,

I'll close this issue assuming that fix in 1.2.2 and 1.3.0 works for you. Attached PR adds a logger count assertion to the stress test. Stress test was showing the same logger leak reported here.

Thanks for reporting this problem!

@if6was9
Copy link
Author

if6was9 commented May 17, 2017

I believe the issue is resolved. Thank you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants