From f195b744a90fa8d3a84c87d323a9d919e75c6c44 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon, 26 Aug 2024 16:42:31 +0200
Subject: [PATCH] build(deps): Bump quarkus.version from 3.13.2 to 3.14.0
 (#367)

See discussion here: https://github.com/orgs/quarkiverse/discussions/228#discussioncomment-10452027

It's now in a worse state than before (with `-Werror` removed and the new config system not working to contributors the same way any more than the old). Let's see how long the legacy annotation processor is actually still maintained.


* build(deps): Bump quarkus.version from 3.13.2 to 3.14.0

Bumps `quarkus.version` from 3.13.2 to 3.14.0.

Updates `io.quarkus:quarkus-bom` from 3.13.2 to 3.14.0
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](https://github.com/quarkusio/quarkus/compare/3.13.2...3.14.0)

Updates `io.quarkus:quarkus-maven-plugin` from 3.13.2 to 3.14.0

Updates `io.quarkus:quarkus-extension-processor` from 3.13.2 to 3.14.0

Updates `io.quarkus:quarkus-extension-maven-plugin` from 3.13.2 to 3.14.0
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](https://github.com/quarkusio/quarkus/compare/3.13.2...3.14.0)

---
updated-dependencies:
- dependency-name: io.quarkus:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.quarkus:quarkus-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.quarkus:quarkus-extension-processor
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.quarkus:quarkus-extension-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Switch to legacy config.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Simons <michael.simons@neo4j.com>
---
 pom.xml | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/pom.xml b/pom.xml
index e8ac4f4..8defde3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -55,7 +55,7 @@
 		<docker-maven-plugin.version>0.45.0</docker-maven-plugin.version>
 		<exec-maven-plugin.version>3.4.1</exec-maven-plugin.version>
 		<graalvm.version>23.0.5</graalvm.version>
-		<java-module-name />
+		<java-module-name/>
 		<java.version>17</java.version>
 		<junit.jupiter.version>5.8.2</junit.jupiter.version>
 		<maven-checkstyle-plugin.version>3.5.0</maven-checkstyle-plugin.version>
@@ -83,7 +83,7 @@
 		<nexus-staging-maven-plugin.version>1.6.13</nexus-staging-maven-plugin.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<quarkus-neo4j.version>4.2.2</quarkus-neo4j.version>
-		<quarkus.version>3.13.2</quarkus.version>
+		<quarkus.version>3.14.0</quarkus.version>
 		<sortpom-maven-plugin.version>4.0.0</sortpom-maven-plugin.version>
 	</properties>
 
@@ -153,7 +153,7 @@
 					<artifactId>maven-compiler-plugin</artifactId>
 					<version>${maven-compiler-plugin.version}</version>
 					<configuration>
-						<forceJavacCompilerUse>true</forceJavacCompilerUse>
+						<forceLegacyJavacApi>true</forceLegacyJavacApi>
 						<compilerArgs>
 							<arg>-Xlint:all,-options,-path,-processing,-classfile</arg>
 							<!-- -classfile due to some weird stuff happening in testCompile. -->
@@ -161,6 +161,24 @@
 							<arg>-parameters</arg>
 						</compilerArgs>
 					</configuration>
+					<executions>
+						<execution>
+							<id>default-compile</id>
+							<configuration>
+								<forceLegacyJavacApi>true</forceLegacyJavacApi>
+								<compilerArgs>
+									<arg>-Xlint:all,-options,-path,-processing,-classfile</arg>
+									<arg>-parameters</arg>
+									<!--
+										Add as a 2nd execution, as the option below always issues a warning, which cannot be suppressed by -processing.
+										Migration to @ConfigMapping does not work with properties that have a non `quarkus` prefix, see
+										https://github.com/orgs/quarkiverse/discussions/228#discussioncomment-10452027
+										-->
+									<arg>-AlegacyConfigRoot=true</arg>
+								</compilerArgs>
+							</configuration>
+						</execution>
+					</executions>
 				</plugin>
 				<plugin>
 					<groupId>org.apache.maven.plugins</groupId>
@@ -204,7 +222,8 @@
 						<configLocation>etc/checkstyle/config.xml</configLocation>
 						<suppressionsLocation>etc/checkstyle/suppressions.xml</suppressionsLocation>
 						<headerLocation>etc/checkstyle/java-header.txt</headerLocation>
-						<encoding>${project.build.sourceEncoding}</encoding>
+						<inputEncoding>${project.build.sourceEncoding}</inputEncoding>
+						<outputEncoding>${project.build.sourceEncoding}</outputEncoding>
 						<consoleOutput>true</consoleOutput>
 						<failsOnError>true</failsOnError>
 						<includeTestSourceDirectory>true</includeTestSourceDirectory>
@@ -299,7 +318,7 @@
 								<requireJavaVersion>
 									<version>${java.version}</version>
 								</requireJavaVersion>
-								<DependencyConvergence />
+								<DependencyConvergence/>
 								<requireMavenVersion>
 									<version>${maven.version}</version>
 								</requireMavenVersion>