Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Options can be passed directly to puppeteer.launch #27

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Options can be passed directly to puppeteer.launch #27

merged 1 commit into from
Nov 21, 2017

Conversation

neocotic
Copy link
Owner

This implements the feature requested in #25 by allowing options to be passed to puppeteer.launch.

A new puppeteer option has been added to existing options parameter for API#convert and API#convertFile and a new options parameter has been added to API#createConverter that only contains the puppeteer option.

@neocotic neocotic added this to the 0.3.2 milestone Nov 21, 2017
@neocotic neocotic self-assigned this Nov 21, 2017
@neocotic
Copy link
Owner Author

Unfortunately, I couldn't find a good way to test this right now. I might try to increase coverage in the future.

@neocotic neocotic merged commit 0de3b99 into develop Nov 21, 2017
@neocotic neocotic deleted the feature/puppeteer-options branch November 21, 2017 10:44
@neocotic neocotic mentioned this pull request Nov 21, 2017
Closed
@neocotic neocotic changed the title feat(convert-svg-core): Options can be passed directly to puppeteer.launch Options can be passed directly to puppeteer.launch Nov 21, 2017
@neocotic neocotic mentioned this pull request Nov 21, 2017
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@neocotic neocotic

Labels
accepted feature request
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.
1 participant
@neocotic