Render pipeline failure should block package push to remote

[Catalin-Stratulat-Ericsson]

Tackles #818 and potentially #658.
The main change this PR proposes is that a package who's render pipeline has failed during a [porchctl rpkg push] should not be allowed to go further into git.
There are fundamental issues with the package in this scenario and can lead to more issues down the line for example in #818.
They should be handled by the user on the local version and retry should be attempted until the package's kpt function pipeline succeeds.

[liamfallon]

Looks good but it's a bit light on tests ;-)

[Catalin-Stratulat-Ericsson]

Looks good but it's a bit light on tests ;-)

Yes i thought so too. ill have a look now and add extra test where needed. in my eyes 3 things must be tested with this push.

1. [porchctl rpkg push] when a successful render occurs and package should be pushed to git.
2. [porchctl rpkg push] when a the object has been modified (aka were trying to push a pkg that is not working off the latest version) & package should not be pushed to git.
3. [porchctl rpkg push] when a render fails package should not be pushed to git.

let me know if i am missing anything :)

[Catalin-Stratulat-Ericsson]

/test presubmit-nephio-go-test

[JamesMcDermott]

/approve

[liamfallon]

Looks good but it's a bit light on tests ;-)

Yes i thought so too. ill have a look now and add extra test where needed. in my eyes 3 things must be tested with this push.

1. [porchctl rpkg push] when a successful render occurs and package should be pushed to git.

2. [porchctl rpkg push] when a the object has been modified (aka were trying to push a pkg that is not working off the latest version) & package should not be pushed to git.

3. [porchctl rpkg push] when a render fails package should not be pushed to git.

let me know if i am missing anything :)

They would be good to have.

[kushnaidu]

/approve

[liamfallon]

/approve

[nephio-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, JamesMcDermott, kushnaidu, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liamfallon]

/lgtm