Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make time handling in OCI platform independent #147

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

liamfallon
Copy link
Member

The time handling on the ListTags function in the OCI registry code is not portable, it only works on Linux machines. The updated code below is portable.

@liamfallon
Copy link
Member Author

/test presubmit-nephio-go-test

@efiacor
Copy link
Collaborator

efiacor commented Dec 3, 2024

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 3, 2024
Copy link
Contributor

nephio-prow bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Collaborator

efiacor commented Dec 3, 2024

/test presubmit-nephio-go-test

@nephio-prow nephio-prow bot merged commit 25ec6d3 into nephio-project:main Dec 3, 2024
5 checks passed
@liamfallon liamfallon deleted the time-plat-ind branch December 16, 2024 09:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants