Prevent creating "main" tag and release on Github #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiacor
reviewed
Jan 25, 2025
| @@ -45,9 +46,8 @@ jobs: | |||
| repo_token: ${{ secrets.GITHUB_TOKEN }} | |||
| file: porchctl.tgz | |||
| asset_name: porchctl.tgz | |||
| tag: ${{ github.ref }} | |||
| tag: dev | |||
There was a problem hiding this comment.
Would we need to align test-infra to pick up the correct bin?
https://github.com/nephio-project/test-infra/blob/main/e2e/provision/playbooks/cluster.yml#L141
There was a problem hiding this comment.
Yes, definetly. Will send a co-PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tag named "main" (same as the branch name "main") in the GitHub repo confuses git clients and scripts executing git operations, so we should avoid it if possible.
This 3 character long PR tries to fix the GH action that regularly recreates that tag,