Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent creating "main" tag and release on Github #175

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Prevent creating "main" tag and release on Github #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbb01f
Prevent creating "main" tag and release on Github
kispaljr Jan 24, 2025
df106ce
Enable manual run of porchctl-dev-release
kispaljr Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/porchctl-dev-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ on:
push:
branches:
- main
workflow_dispatch:

jobs:
build:
Expand All @@ -30,7 +31,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '>=1.22.2'
go-version: ">=1.22.2"
- name: Checkout
uses: actions/checkout@v4
with:
Expand All @@ -45,9 +46,8 @@ jobs:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: porchctl.tgz
asset_name: porchctl.tgz
tag: ${{ github.ref }}
tag: dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to align test-infra to pick up the correct bin?
https://github.com/nephio-project/test-infra/blob/main/e2e/provision/playbooks/cluster.yml#L141

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definetly. Will send a co-PR.

overwrite: true
prerelease: true
release_name: Porchctl build from main
body: "This is dev porchctl binary built from main each merge"

Loading