Add unit tests for rpkg commands #84
Conversation
kushnaidu
requested review from
liamfallon,
efiacor,
Catalin-Stratulat-Ericsson and
pauldennehy
|
/retest |
There was a problem hiding this comment.
Can you update the copyright notices on changed files please eg on this file
Copyright 2022,2024 The kpt and Nephio Authors
| if err := v1alpha1.SchemeBuilder.AddToScheme(scheme); err != nil { | ||
| return err | ||
| } | ||
| func UpdatePackageRevisionApproval(ctx context.Context, client client.Client, key client.ObjectKey, new v1alpha1.PackageRevisionLifecycle) error { |
There was a problem hiding this comment.
Nice refactoring on this function.
| @@ -0,0 +1,190 @@ | |||
| // Copyright 2022 The kpt and Nephio Authors | |||
There was a problem hiding this comment.
Can you change the date to 2024 on this and all the other unit test files?
There was a problem hiding this comment.
Will do that now Liam.
|
Unit tests are passing for me locally. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kushnaidu, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change introduces unit tests for most of the rpkg commands with slight modifications to the approve and reject commands to use the controller-runtime client instead of the rest interface.