Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix porchсtl push method for windows #92

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

RomanBudnyk
Copy link
Contributor

we are compiling the porchctl to use it on Windows. the proposed fix is changing the Windows path representation to the Unix-based one.

we are compiling the porchctl to use it on Windows. the proposed fix is changing the Windows path representation to the Unix-based one.
@nephio-prow nephio-prow bot requested review from henderiw and s3wong August 13, 2024 14:25
Copy link

linux-foundation-easycla bot commented Aug 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

nephio-prow bot commented Aug 13, 2024

Hi @RomanBudnyk. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RomanBudnyk RomanBudnyk changed the title fix porchtl push method for windows fix porchсtl push method for windows Aug 13, 2024
@radoslawc
Copy link
Collaborator

/ok-to-test

fix according to kispaljr's comment
@RomanBudnyk
Copy link
Contributor Author

/retest-required

@RomanBudnyk RomanBudnyk requested a review from kispaljr August 17, 2024 08:55
@kispaljr
Copy link
Collaborator

/lgtm

@efiacor
Copy link
Collaborator

efiacor commented Aug 18, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Aug 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, RomanBudnyk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 18, 2024
@nephio-prow nephio-prow bot merged commit a358f84 into nephio-project:main Aug 18, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants