Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

overload from_json_string to support std::string #18

Closed
dvd0101 opened this issue Sep 1, 2016 · 2 comments
Closed

overload from_json_string to support std::string #18

dvd0101 opened this issue Sep 1, 2016 · 2 comments

Comments

@dvd0101
Copy link
Contributor

dvd0101 commented Sep 1, 2016

Since you updated rapidjson to 1.1.0 it's possible to take advantage of the new api to parse a std::string without converting it to a char*.

I can prepare a PR if you are ok with the idea
@netheril96
Copy link
Owner

Go ahead with the PR.

@netheril96
Copy link
Owner

The new API seems to works only with Document, not generic SAX interface.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvd0101 @netheril96