Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: bump node in CI actions #6542

Merged
merged 16 commits into from
May 2, 2024
Merged

fix: bump node in CI actions #6542

merged 16 commits into from
May 2, 2024

Conversation

lemusthelroy
Copy link
Contributor

@lemusthelroy lemusthelroy commented May 1, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Attempting to unblock CI by bumping node version on the GitHub actions for tests.

Bonus track

Flakey telemetry tests were stopping this from being merged, so a fix for this appears in this PR

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner May 1, 2024 08:52
Copy link

github-actions bot commented May 1, 2024

📊 Benchmark results

Comparing with 0ca4ac8

  • Dependency count: 1,329 (no change)
  • Package size: 310 MB ⬆️ 0.00% increase vs. 0ca4ac8
  • Number of ts-expect-error directives: 1,001 (no change)

khendrikse
khendrikse previously approved these changes May 1, 2024
@lemusthelroy
Copy link
Contributor Author

I am not totally sure about my telemetry test fix but want to see if it makes a difference

khendrikse
khendrikse previously approved these changes May 2, 2024
@lemusthelroy
Copy link
Contributor Author

For some reason the Unit tests have not run so just need to work out why those are not being executed. After I can see these have been run, I will be updating the branch rules to match the unit tests that are actually running as specified in this PR.

@lemusthelroy lemusthelroy enabled auto-merge (squash) May 2, 2024 14:52
@lemusthelroy lemusthelroy merged commit 2c27e2c into main May 2, 2024
47 checks passed
@lemusthelroy lemusthelroy deleted the ljt/bump-node-ci branch May 2, 2024 15:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants