Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: use dev server settings from site #6668

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

davbree
Copy link
Contributor

@davbree davbree commented May 27, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Support dev server UI configuration and use it as default

ref CRE-1188


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@davbree davbree requested a review from a team as a code owner May 27, 2024 09:10
Copy link

github-actions bot commented May 27, 2024

📊 Benchmark results

Comparing with 52ac076

  • Dependency count: 1,235 (no change)
  • Package size: 295 MB ⬆️ 0.00% increase vs. 52ac076
  • Number of ts-expect-error directives: 989 (no change)

Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davbree davbree enabled auto-merge (squash) May 28, 2024 05:42
@davbree davbree merged commit 9ece8fe into main May 28, 2024
48 checks passed
@davbree davbree deleted the devserver-site-settings branch May 28, 2024 05:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants