Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: remove the lm (large media) subcommand #6956

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

sarahetter
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This has been deprecated for more than a year and gets less than one invocation a day. It's time 🫡


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Dec 20, 2024

📊 Benchmark results

Comparing with 54969fd

  • Dependency count: 1,214 ⬇️ 1.07% decrease vs. 54969fd
  • Package size: 317 MB ⬇️ 0.28% decrease vs. 54969fd
  • Number of ts-expect-error directives: 850 ⬇️ 2.94% decrease vs. 54969fd

@sarahetter sarahetter changed the title feat!: remove the lm (large media) subcommand feat!: remove the lm (large media) and addons subcommands Dec 20, 2024
@sarahetter sarahetter changed the title feat!: remove the lm (large media) and addons subcommands feat!: remove the lm (large media) subcommand Dec 20, 2024
@sarahetter sarahetter marked this pull request as ready for review December 20, 2024 20:02
@sarahetter sarahetter requested review from a team as code owners December 20, 2024 20:02
@sarahetter sarahetter merged commit afdfe46 into main Dec 20, 2024
49 checks passed
@sarahetter sarahetter deleted the sarahetter/remove-lm branch December 20, 2024 20:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants