fix: hide dynamic ssg endpoint resolution under environment variable #7011
Conversation
📊 Benchmark resultsComparing with da7f42e
|
| @@ -354,7 +354,10 @@ const serveRedirect = async function ({ | |||
| const reqUrl = reqToURL(req, req.url) | |||
|
|
|||
| const staticFile = await getStatic(decodeURIComponent(reqUrl.pathname), options.publicFolder) | |||
| const endpointExists = !staticFile && (await isEndpointExists(decodeURIComponent(reqUrl.pathname), options.target)) | |||
| const endpointExists = | |||
There was a problem hiding this comment.
Can we use a feature flag instead?
There was a problem hiding this comment.
Well, we are using env vars for this in other places. Also, I want it to be global solution for dev servers via env var (so dev server when initializing sets this env var, while feature flag is set per user, isn't it?)
There was a problem hiding this comment.
while feature flag is set per user, isn't it?
You can target a feature flag for all users or for a subset of them using whatever targeting criteria you want.
There was a problem hiding this comment.
I see, but for now it's easier to do it like that (+ also we use the same approach for other dev-server related things)
Anyway, I still want to bring it to discussion and move it out from the "behind curtain" block
🎉 Thanks for submitting a pull request! 🎉
Summary
Hides this functionality under env var for better control/transition period while discussing it.
Discussion at https://netlify.slack.com/archives/C03ETTLQ9BP/p1737489833462809
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)