-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add API authentication support #217
Conversation
0.7.3-handle-secrets.0
Fix eslint and prettier
Expands on the GraphQL query for the service auths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I haven't tested the typings though, so they will need to be looked at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like a serverless pod review before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a few comments, but none of them are blocking.
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
…ctions-1 into feat/secrets-handling-dynamic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A continuation of the work done in #104 that adds in dynamic fetching of secrets, and lays the groundwork for some backend changes coming to how the secrets will be passed in to functions in the future.