Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add API authentication support #217

Merged
merged 19 commits into from
Nov 17, 2021

Conversation

sgrove
Copy link
Contributor

@sgrove sgrove commented Nov 16, 2021

A continuation of the work done in #104 that adds in dynamic fetching of secrets, and lays the groundwork for some backend changes coming to how the secrets will be passed in to functions in the future.

@sgrove sgrove requested review from tiffafoo and ascorbic November 16, 2021 16:36
@sgrove sgrove added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 16, 2021
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I haven't tested the typings though, so they will need to be looked at.

.eslintrc.js Outdated Show resolved Hide resolved
src/function/handler.ts Outdated Show resolved Hide resolved
src/lib/secrets.js Outdated Show resolved Hide resolved
src/lib/secrets.js Outdated Show resolved Hide resolved
src/lib/secrets.js Outdated Show resolved Hide resolved
@ascorbic ascorbic changed the title Feat/secrets handling dynamic feat: add API authentication support Nov 17, 2021
ascorbic
ascorbic previously approved these changes Nov 17, 2021
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like a serverless pod review before merging

eduardoboucas
eduardoboucas previously approved these changes Nov 17, 2021
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few comments, but none of them are blocking.

src/lib/secrets.ts Outdated Show resolved Hide resolved
src/lib/secrets_helper.ts Show resolved Hide resolved
src/lib/secrets_helper.ts Outdated Show resolved Hide resolved
src/lib/secrets_helper.ts Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
@sgrove sgrove dismissed stale reviews from eduardoboucas and ascorbic via c2d762d November 17, 2021 11:27
@sgrove sgrove marked this pull request as ready for review November 17, 2021 11:32
@sgrove sgrove removed the request for review from tiffafoo November 17, 2021 11:42
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kodiakhq kodiakhq bot merged commit 57ff1da into netlify:main Nov 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants