Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: make Response.body optional #63

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: make Response.body optional #63

merged 1 commit into from
May 5, 2021

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented May 5, 2021 •
edited
Loading

Which problem is this pull request solving?

Makes the body property in Response optional.

List other issues or pull requests related to this problem

Closes #57.

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label May 5, 2021
@eduardoboucas eduardoboucas requested a review from a team as a code owner May 5, 2021 14:29
@eduardoboucas eduardoboucas self-assigned this May 5, 2021
@eduardoboucas eduardoboucas merged commit 9932e07 into main May 5, 2021
@eduardoboucas eduardoboucas deleted the fix/body-optional branch May 5, 2021 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@ehmicky ehmicky ehmicky approved these changes

Assignees

@eduardoboucas eduardoboucas

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

body should be optional
3 participants
@eduardoboucas @ehmicky @erezrokah