Adds support for passing component type or element to PreviewContent, supports React.forwardRef #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit cf1bb33 |
|
Deploy preview for cms-demo ready! Built with commit cf1bb33 |
erquhart
approved these changes
Apr 12, 2018
|
Apologies for the delay on this, merging up. |
brianlmacdonald
pushed a commit
to brianlmacdonald/netlify-cms
that referenced
this pull request
May 23, 2018
… supports React.forwardRef (decaporg#1248)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue while trying to pass a HOC that returned a
React.forwardRef. This adds an appropriate check of whether tocloneorcreatethe preview element.Note: Adds dependancy
react-is, which is recommended by the react team