Prevent login if Git Gateway is disabled. #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
commented
Apr 20, 2018
| @@ -78,7 +78,11 @@ export default class API { | |||
| if (contentType && contentType.match(/json/)) { | |||
| return this.parseJsonResponse(response); | |||
| } | |||
| return response.text(); | |||
| const text = response.text(); | |||
| if (!response.ok) { | |||
There was a problem hiding this comment.
@Benaiah Is there any problem internally if we reject on not-OK responses for all content-types? We do on JSON responses already (see parseJsonResponse).
There was a problem hiding this comment.
@tech4him1 yeah - I actually thought it was supposed to be doing so already. If the caller is expecting a non-ok response it can catch the APIError.
|
Deploy preview for cms-demo ready! Built with commit 2a58992 |
|
Deploy preview for netlify-cms-www ready! Built with commit 2a58992 |
erquhart
approved these changes
May 12, 2018
brianlmacdonald
pushed a commit
to brianlmacdonald/netlify-cms
that referenced
this pull request
May 23, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #1272.
If Git Gateway was disabled, we were still allowing the user to log in, which can cause them to lose their work when they cannot save it.
- Test plan
Manually tested with both scenarios: #1272 (comment).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)