Fix proptype warning #998
Merged
Fix proptype warning #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 26c6385 |
|
Deploy preview ready! Built with commit 26c6385 |
This was referenced Jan 9, 2018
erquhart
approved these changes
Jan 19, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997.
- Summary
Load any page and this appears in the console:
About the change, later
newEntryUrlis evaluated on a truey/falsey base and used directly as a string, so we can supply an empty string and it will be evaluated as falsey just the same.- Test plan
Load any page, warning shouldn't appear in the console.
- Description for the changelog
Fix PropType warning in console.