fix: compile away node:-namespaced imports (#806)

* chore: reproduce problem

* fix: rewrite node:-imports on esbuild

* chore: only require esbuild-compiled bundles

* chore: require file for Node >= 14.18

* chore: gte wants a version, not an expression

* chore: i should really run tests locally

* chore: add test for cjs files, describe better

* Update main.js

Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>

src/runtimes/node/bundlers/esbuild/plugin_node_builtin.ts

@@ -3,7 +3,7 @@ import type { Plugin } from '@netlify/esbuild'
 const getNodeBuiltinPlugin = (): Plugin => ({
   name: 'builtin-modules',
   setup(build) {
-    build.onResolve({ filter: /^node:/ }, () => ({ external: true }))
+    build.onResolve({ filter: /^node:/ }, (args) => ({ path: args.path.slice('node:'.length), external: true }))
   },
 })
 

tests/fixtures/node-force-builtin-cjs/function.js

@@ -0,0 +1,5 @@
+const console = require('node:console')
+
+exports.handler = () => {
+  console.log('hello world')
+}

tests/main.js

@@ -2251,11 +2251,11 @@ testMany(
 )
 
 testMany(
-  'Handles built-in modules required with the `node:` prefix',
+  'Handles built-in module added in v16 required with the `node:` prefix',
   ['bundler_default', 'bundler_default_nft', 'bundler_nft', 'bundler_esbuild', 'bundler_esbuild_zisi'],
   async (options, t) => {
     t.plan(3)
-    const { tmpDir, files } = await zipFixture(t, 'node-force-builtin', {
+    const { tmpDir, files } = await zipFixture(t, 'node-force-builtin-v16', {
       opts: { config: { '*': { ...options } } },
     })
 
@@ -2282,8 +2282,22 @@ testMany(
 testMany(
   'Handles built-in modules imported with the `node:` prefix',
   ['bundler_default', 'bundler_default_nft', 'bundler_nft', 'bundler_esbuild', 'bundler_esbuild_zisi'],
+  async (options, t, bundler) => {
+    const importSyntaxIsCompiledAway = bundler.includes('esbuild')
+    const zip = importSyntaxIsCompiledAway ? zipNode : zipFixture
+    await zip(t, 'node-force-builtin-esm', {
+      opts: options,
+    })
+  },
+)
+
+testMany(
+  'Handles built-in modules required with the `node:` prefix',
+  ['bundler_default', 'bundler_default_nft', 'bundler_nft', 'bundler_esbuild', 'bundler_esbuild_zisi'],
   async (options, t) => {
-    await zipFixture(t, 'node-force-builtin-esm', {
+    const nodePrefixIsUnderstood = semver.gte(nodeVersion, '14.18.0')
+    const zip = nodePrefixIsUnderstood ? zipNode : zipFixture
+    await zip(t, 'node-force-builtin-cjs', {
       opts: options,
     })
   },