Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix : areas not displayed after "update" event #136

Closed
neveldo opened this issue Nov 24, 2015 · 2 comments
Closed

Bugfix : areas not displayed after "update" event #136

neveldo opened this issue Nov 24, 2015 · 2 comments

Comments

@neveldo
Copy link
Owner

neveldo commented Nov 24, 2015

Here is a bug regarding the legend and the "update" event that can be saw on : dataviz_example.html .

Use case :

1 / Load the dataviz_example.html example
2 / Click on the 'less that 5M' slice to disable all the related countries
3 / Switch to the year 2010.

The China country (this is an example, but the issue affect the other states) is not displayed again while it should.

@neveldo neveldo changed the title Bug in dataviz_example.html : areas not displayed after "update" event Bugfix : areas not displayed after "update" event Nov 24, 2015
@Indigo744
Copy link
Collaborator

The problem appears because of our work on setLegendElemState.
Before: the legend state was always reset to "show", hence no problem
After: the legend state is defined by setLegendElemState

Solution: at the beginning of update, if the user redefined an area, plot or legend, then reset all legend to show.

@neveldo
Copy link
Owner Author

neveldo commented Nov 25, 2015

Thank you for having fixed it :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants